worldbank / dime-standards

Repository with resources for DIME's research standards and coding standards
47 stars 40 forks source link

Added Sampling-Randomization and HFCs Checklists #45

Closed Avnish95 closed 1 year ago

Avnish95 commented 1 year ago

Ah got it, we can change it to “in this checklist” then.

On Thu, Feb 16, 2023 at 10:56, Kristoffer Bjärkefur < @.***> wrote:

@.**** commented on this pull request.

In dime-coding-standards/checklists/tex/hfcs_checklist.tex https://github.com/worldbank/dime-standards/pull/45#discussion_r1108686774 :

  • \titleBox{
  • \textcolor{white}{\LARGE{\textbf{DIME Analytics \ Peer Code Review - High-Frequency Checks Checklist}} \
  • \Large\textbf{{v1.0}}}
  • }
  • \dimeTextField{time}{2.5 cm}{Reviewer:}
  • \dimeTextField{time}{2.5 cm} {Coder:}
  • \textbf{NOTE:} Make sure that fill out this checklist \textbf{ONLY IF} your partner's submission includes request to review \textbf{high-frequency checks}.
  • \section*{High-frequency checks}
  • This checklist lists important factors to consider while reviewing your code review partner's \textbf{high-frequency checks}. Please fill this checklist, and submit it as an attachment when you submit \href{https://survey.wb.surveycto.com/collect/code_review_summary?caseid=}{this detailed form.}
  • \hfill \break
  • \textbf{Note:} We are piloting this checklist as part of improving the code review process. The questions in this list are therefore \textbf{not required}, and we welcome your feedback on the points listed below.

The questions in this list are therefore What do you refer to as "this list" here? I think it is ambiguous if you refer to the two questions in the "General" subsection or if you mean all questions in this document.

— Reply to this email directly, view it on GitHub https://github.com/worldbank/dime-standards/pull/45#pullrequestreview-1301777583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOZGY3GK22F4HKXJTZMUT6DWXZE2LANCNFSM6AAAAAAUYI5374 . You are receiving this because you authored the thread.Message ID: @.***>

-- Avnish D. Singh Impact Evaluation Consultant - The World Bank Master’s in Economics (Columbia University ‘19) +1-929-358-4355

Avnish95 commented 1 year ago

How about “General” and “HFC Contents”?

On Thu, Feb 16, 2023 at 11:01, Kristoffer Bjärkefur < @.***> wrote:

@.**** commented on this pull request.

In dime-coding-standards/checklists/tex/hfcs_checklist.tex https://github.com/worldbank/dime-standards/pull/45#discussion_r1108693490 :

  • This checklist lists important factors to consider while reviewing your code review partner's \textbf{high-frequency checks}. Please fill this checklist, and submit it as an attachment when you submit \href{https://survey.wb.surveycto.com/collect/code_review_summary?caseid=}{this detailed form.}
  • \hfill \break
  • \textbf{Note:} We are piloting this checklist as part of improving the code review process. The questions in this list are therefore \textbf{not required}, and we welcome your feedback on the points listed below.
  • \subsection*{General}
  • \begin{itemize}
  • \setlength\itemsep{-0.1em}
  • \item[] \dimeCheckBox{The data shared does not contain any personally-identifying information (PII).}
  • \item[] \dimeCheckBox{The code creates a tracking sheet (or dashboard) to track progress of the survey.}
  • \end{itemize}
  • \hfill \break +The following sections cover various aspects of the \textbf{contents of the high-frequency checks} included in the package, but not all may apply to the high-frequency checks you are reviewing.

I find it a bit tricky to follow what description goes to what section.

Consider making \subsection{General} a section instead of a subsection. Call it \section{General Questions} , then before this row have a new section \section*{HFC Questions}.

— Reply to this email directly, view it on GitHub https://github.com/worldbank/dime-standards/pull/45#pullrequestreview-1301787724, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOZGY3CA72B7VVWDNZH7P33WXZFNVANCNFSM6AAAAAAUYI5374 . You are receiving this because you authored the thread.Message ID: @.***>

-- Avnish D. Singh Impact Evaluation Consultant - The World Bank Master’s in Economics (Columbia University ‘19) +1-929-358-4355

kbjarkefur commented 1 year ago

Making a general point here instead of each time "randomization" is used in the doc to refer "random treatment assignment"

See here how we carefully call this random treatment assignment and just "randomization" is a process in computer science, not a step in research. https://worldbank.github.io/dime-data-handbook/measurement.html#creating-research-design-variables-by-randomization

Update each time "randomization" is used to "random treatment assignment" or just "treatment assignment" even in the name of the document.

Avnish95 commented 1 year ago

I've made edits and updated both checklists based on comments.