search

worldbank / dkanr

General purpose R client to the DKAN Open Data platform
Other
7 stars 3 forks source link

Add to query-builder test suite #8

Closed seladore closed 7 years ago

seladore commented 7 years ago

dkanr/tests/testthat/test-query_builder.R

File now includes the following tests, building off of Tony's original file:

  1. single and multiple filters are built correctly with filters_to_text_query
  2. single and multiple fields are built correctly with build_search_query
  3. single and multiple filters & fields together are built correctly with build_search_query
  4. page number and size respectfully are built correctly with build_search_query
  5. build_search_query with all parameters is built correctly

The constant variables are also declared on the top. Let me know if there are any additional tests that should be included.

seladore commented 7 years ago

Ok, sounds good. I'll work on adding those and other edge cases as well.