iecodebook: run file tests - Githubissues

worldbank / iefieldkit

Stata commands designed for Impact Evaluations field work. These are tools that are used during/after a survey in the field for data quality monitoring.

MIT License

38 stars 18 forks source link

iecodebook: run file tests #157

Closed luizaandrade closed 2 years ago

luizaandrade commented 4 years ago

Major

[x] trim() option not working
[x] if not working: "if not allowed"
[x] in not working: "in range not allowed"

Minor

[x] Option missingvalues not working: only add new missing labels to yesno label
[ ] No error thrown when using options missingvalues and drop with template subcommand -- wontfix, it doesn't make a difference on the command

bbdaniels commented 4 years ago

Just going to reply these in the order I tackle them. Minor ones first, both of which I think don't need fixes now:

missingvalues only works for labels that are specified in the choices column. This goes with the principle of "don't make changes that aren't requested". If you copy the variable into the edits zone, the corresponding label will get picked up correctly.
template doesn't throw errors for arbitrary options that are allowed in other commands, as long as they don't do anything. I suppose it could, but functionality wouldn't be affected in any way. I will leave this unfixed for now if that's ok?

bbdaniels commented 4 years ago

Not going to address trim() here. It is very experimental in this release and probably wouldn't be included if I would rewrite from scratch; but it is, as I wanted the framework in place. Major improvements are underway in #154 and will be finished for next release. It's a significant extension in syntax and functionality that I think is not appropriate for this revision.

bbdaniels commented 4 years ago

if/in : This is addressed by removing them from the article and documentation. There is no way to get this to work in a sensible and consistent way that provides useful functionality. Was intended as a shortcut for people to subset their data, but far better that they do that explicitly.

luizaandrade commented 4 years ago

template doesn't throw errors for arbitrary options that are allowed in other commands, as long as they don't do anything. I suppose it could, but functionality wouldn't be affected in any way. I will leave this unfixed for now if that's ok?

I think for consistency, it should throw errors for all options that are not used, since it throws for some

bbdaniels commented 4 years ago

template doesn't throw errors for arbitrary options that are allowed in other commands, as long as they don't do anything. I suppose it could, but functionality wouldn't be affected in any way. I will leave this unfixed for now if that's ok?

I think for consistency, it should throw errors for all options that are not used, since it throws for some

I agree but at this moment I am afraid of breaking something by implementing this wrong and not foreseeing something that needs to be passed through....

bbdaniels commented 4 years ago

Documentation updated for all the above in e0e4f84d5be2f7f4db594a8c6dfb7c0a0358581b