worldbank / iefieldkit

Stata commands designed for Impact Evaluations field work. These are tools that are used during/after a survey in the field for data quality monitoring.
MIT License
38 stars 18 forks source link

iecodebook: major extensions to [export] functionality #163

Closed bbdaniels closed 3 years ago

bbdaniels commented 3 years ago

iecodebook export is now majorly upgraded as a data handling command. This PR includes the following new features:

This issue supersedes all other iecodebook issues and is important when it can be reviewed as these tools are majorly needed (by me, at least).

kbjarkefur commented 3 years ago

I have never used this command. Can you tell me what to run and what you want me to look at? Otherwise I am not sure what to do.

bbdaniels commented 3 years ago

Yeah hold on. I am trying to put it all into one big thing for the moment. I will write up detailed instructions after I run ad hoc checks to make sure nothing is screwed up. Thanks! On Jul 10, 2020, 3:49 PM -0400, Kristoffer Bjärkefur notifications@github.com, wrote:

I have never used this command. Can you tell me what to run and what you want me to look at? Otherwise I am not sure what to do. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

luizaandrade commented 3 years ago
bbdaniels commented 3 years ago

@luizaandrade cb9e96399dde7701dcf311cc64291a5cd9fe250d is a simple fix that addresses (D) above. I think it is an error with quotation marks, not forward slashes. Need you to confirm this one.

bbdaniels commented 3 years ago

(C) will be resolved by writing reset in the options since this is needed to write a new signature. 4753ba9e9717b7b83bffb92c10be816d61501bbe adds an error message to this effect.

bbdaniels commented 3 years ago

For (E) I now return an error in 46ce86bd17c86918f9afbdc3a30ace11e38ba816 if file extension is not specified or not .do. People can write out their file paths....

bbdaniels commented 3 years ago

(A) is resolved by storing data in memory before loading new data. d011be4345316ef4d07d429ed4589d98460736fb @luizaandrade can you confirm that this doesn't break any of the template functionality, especially in append. I couldn't break it at this stage but since template in particular may call this repeatedly I can imagine there might be a case where it fails.

bbdaniels commented 3 years ago

In c6126c3511208d029ef234b78d5f826d3441cf3b I resolve (B) by allowing an override of the default filename with saveas(). The replace option is global, is that ok?

luizaandrade commented 3 years ago