ietestform: Check for outdated syntax

[stevenglover]

Suggestion to add a check for outdated syntax that could create issues. The two that come to my mind are:

• position(..), should be index()
• jr:choice-name(), should be choice-label() [this is a recent addition to CTO]

[kbjarkefur]

I like this. Can you help me confirm that these are the columns where you could use either of those:

• survey tab
  • relevance
  • constraint
  • calculation
  • repeat count ??
• choice tab
  • no usage
• settings tab
  • no usage

[stevenglover]

I don't think you would want to use this on repeat count, but it's possible I suppose. Agree with the others. Another usage of position(..)/index() could be on choice_filter in the survey tab, though I've never used it myself.

[kbjarkefur]

Yeah I think it is unlikely that there is a use case that make sense for using it in the _repeatcount column, but since it is a column where functions like position(..)/index() can be used, we should look for it there.

Thanks for thinking of _choicefilter as well, added it below:

• survey tab
  • relevance
  • constraint
  • calculation
  • repeat_count
  • choice_filter
• choice tab
  • no usage
• settings tab
  • no usage

[roshni13khincha]

Added in fb4af13