search

worldbank / iefieldkit

Stata commands designed for Impact Evaluations field work. These are tools that are used during/after a survey in the field for data quality monitoring.
MIT License
38 stars 18 forks source link

Fix pause bug -- needs SSC update #252

Closed bbdaniels closed 1 year ago

kbjarkefur commented 1 year ago

Merge into develop if include in next version, or merge into a version branch if this needs a fast track update to SSC.

bbdaniels commented 1 year ago

Is there anything else in the release queue or will it be a while? I think this should move pretty quickly, it's very obnoxious as it requires the user to either disable pause or to q through the pauses. We missed it in testing because we had pause off so the test file ran without issue....

kbjarkefur commented 1 year ago

I am not aware of any. So up to you. I included a minor thing from ietestform into develop just now.

bbdaniels commented 1 year ago

It can wait but not forever; I'll merge this now. If there is nothing more by the end of the FY I say we release then. I think it would be good in general to have a more regular (June/December) release cycle for all our code products so that these things can go out in a timely fashion even when they are minor.

kbjarkefur commented 1 year ago

A regular release cycle is not a bad idea. Its like what the real programmers calls sprints. But they tend to be 2 weeks and not 6 months. :)

luizaandrade commented 1 year ago

if this is a bug fix, I'd say let's just go ahead and do a release now

kbjarkefur commented 1 year ago

I have no objection to releasing either.

bbdaniels commented 1 year ago

Can we resolve the two open PRs? I just added one for @luizaandrade's feature request and there is a very old one that I don't know if we are using or not.

luizaandrade commented 1 year ago

Thanks, @bbdaniels! I think we should merge Denisse's PR, since it does something quite useful. It will take some work to do it though, so I think this is a to-do for the next big version release.

bbdaniels commented 1 year ago

OK. can we add that to the agenda for next Thursday then? I think these are the kinds of things we should discuss!