worldbank / pddcs

pddcs: fetch raw data from different sources and prepare datasets for upload to DCS.
https://worldbank.github.io/pddcs/
Other
1 stars 1 forks source link

New files to push #19

Closed hkashiwase closed 3 years ago

hkashiwase commented 3 years ago

Dear Aleksander,

I have changed the two files (1. fetch-unicef.R 2.internal-variables.R) to add 4 new UNICEF indicators and committed in R. However, it doesn't seem that I can push the files in Git. I have created a new branch called "add_unicef_indicators". Could you help me with how to push the files? Thanks for your help.

Haruna

image image

Aeilert commented 3 years ago

Dear Haruna,

Thanks for updating the files. I saw you already pushed some files to the add_unicef_indicators branch on Github. But I can see how the messages in RStudio can be a bit confusing.

From the "log on failed" message it looks like RStudio is not able to access your Github account. Maybe take a look at Connect RStudio to Git and GitHub to see if these steps could help. The "everything up-to-date" message does however indicate that all your local commits are already pushed, so check the Github branch https://github.com/worldbank/pddcs/tree/add_unicef_indicators to see if your changes are already there.

Once you have pushed the final changes you can create a Pull Request and assign me as a reviewer.

Best, Aleksander

hkashiwase commented 3 years ago

Dear Aleksander, thank you for your instruction! I have just submitted a pull request. Please let me know if you find any problems.

Haruna