Prepare package for CRAN release

worldbank / pipr

R client to the PIP API

https://worldbank.github.io/pipr

Other

12 stars 4 forks source link

Prepare package for CRAN release #18

Closed Aeilert closed 2 years ago

Aeilert commented 2 years ago

[x] Make sure there are no errors or warnings in R CMD check on local OS
[x] Use rhub to ensure R CDM checks also pass on other major OS
[x] Make sure all notes in R CMD check can be explained briefly. Preferably there should be 0 notes.
[x] Assign a version number (update DESCRIPTION and NEWS.md)
[x] Confirm alignment with CRAN policies
[x] Disable unit-tests for CRAN submission (Please see issue #22 )

shahronak47 commented 2 years ago

@tonyfujs To use rhub your email (tfujs@worldbank.org) needs to be validated first. You can run rhub::validate_email() to do that.

Secondly, should I disable unit tests or just re-write them as mentioned here https://github.com/PIP-Technical-Team/pipr/issues/22 which will solve both the issues?

tonyfujs commented 2 years ago

Thanks @shahronak47 You can run rhub using your own email, it does not have to be my email.

As for the unit tests, let's just disable them for now (or add a logical var that allows us to switch them on and off on demand), and prepare mocking in a different PR.