worldbank / pipr

R client to the PIP API
https://worldbank.github.io/pipr
Other
13 stars 4 forks source link

Fix cran feedback CU-8677zdwwa #62

Closed randrescastaneda closed 1 year ago

randrescastaneda commented 1 year ago

Related GitHub issues and pull requests

Summary

Hi @tonyfujs .

I fixed 4 out of the 6 items in #60 . The last items was converted into issue #61, so I'll take a look at it separately. However, the following item is not clear to me:

Please write about the structure of the output (class) and also what the output means. (If a function does not return a value, please document that too, e.g. \value{No return value, called for side effects} or similar)

I checked and removed unnecessary error classes, like "pipr_error", and also explained the class "pip_api" in the return field of the roxygen documentation of every function. However, I don't what else is needed. all the checks passed (see image below).

Best,

image

randrescastaneda commented 1 year ago

Task linked: CU-8677zdwwa Fix CRAN submission feeback