fix issue with global environment CU-8677zdvv4

worldbank / pipr

R client to the PIP API

https://worldbank.github.io/pipr

Other

13 stars 4 forks source link

fix issue with global environment CU-8677zdvv4 #63

Open randrescastaneda opened 1 year ago

randrescastaneda commented 1 year ago

Hi @tonyfujs,

I think this PR is ready to merge. It solves the issue of the caching. The only thing that is missing is the ability to turn the caching on or off. I just thought about it. I don't think that is super important, either is it too difficult to implement. @shahronak47 , could you please take a look and let me know?

Thanks. Best,

randrescastaneda commented 1 year ago

Hi @randrescastaneda , I just added a couple of trivial suggestions

Hi @shahronak47 , good suggestions. Could you please implement them? I can't right now. If you can't, I'll do it in a few hours. Thanks!

randrescastaneda commented 1 year ago

Hi @randrescastaneda , I just added a couple of trivial suggestions

HI Ronak. I just implemented your suggestions. Thanks. Best.