worldcoin / signup-sequencer

signup-sequencer repository
MIT License
67 stars 33 forks source link

Change id commitment not found status code from 400 to 404 #717

Closed mircobordoni closed 3 months ago

mircobordoni commented 4 months ago

Motivation

The signup-sequencer currently doesn't make a distinction between identity commitments not being in the merkle tree or being invalid. This makes it harder to build logic that can differentiate those cases in the clients to this service.

Solution

In this PR we change the IdentityCommitmentNotFound to return a 404 - NotFound instad of a 400 - BadRequest.