search

worldcompany / djangoembed

rich media consuming and providing with django
http://djangoembed.readthedocs.org
MIT License
138 stars 38 forks source link

Include a context dictionary in views #30

Closed okke-formsma closed 12 years ago

okke-formsma commented 12 years ago

Our templates expect a context dictionary, which might be pre-filled with values in middleware. This patch adds the request context object to template rendering calls.

fcurella commented 12 years ago

How about using RequestContext instead of a plain dictionary?

okke-formsma commented 12 years ago

Meh, I'm trying to fix my commit but somehow I'm getting errors from the GitHub app. Deleting my fork and then creating a new one didn't really seem to work. Please wait a minute, I'm trying to make a new pull request in a minute :)

okke-formsma commented 12 years ago

I nuked my repo as it made my github app crash. Re-forking your repo doesn't seem to work, I hope it'll magically be better in a few days orso.

Anyway, could you add a request keyword argument to the view code, line 91? Also, don't forget to import RequestContext.

context=RequestContext(request)