search

worldia / textmaster-api

Simple PHP client for the Textmaster API
1 stars 5 forks source link

Make Model Object autonomous. #17

Closed Pitoune closed 8 years ago

Pitoune commented 8 years ago

Add a Manager to get them. Fix issue #8 and issue #9

cdaguerre commented 8 years ago

@pitoune Maybe we could make a separate PR fixing CS in the entire repo because all those unrelated CS fixes make the code review all little complicated. The Scrutinizer issues about duplication make sense here, could you have a look?

In addtition, I think your implementation of 

Project::addDocument($title, $instructions, $originalContent)

should be renamed to 

Project::createDocument($title, $instructions, $originalContent)

and that we should add

Project::addDocument(DocumentInterface $document)

Also, mandatory parameters should always be first in the method signature and I believe that $instructions are optional. What about $title?

Pitoune commented 8 years ago

Replaced by #24