search

worldia / textmaster-api

Simple PHP client for the Textmaster API
1 stars 5 forks source link

AbstractObject::getProperty() should be public #73

Closed jmleroux closed 8 years ago

jmleroux commented 8 years ago

I need to access the updated_at property of a Document response, but there is no getter to acces it from a Document object. I think the getProperty should be public to let developpers access any document property. Plus, if the Document response change, devs will be able to access new properties.

The alternative could be to make a getter for each and every property.

Regards, JM

cdaguerre commented 8 years ago

We would rather stick to concrete getters and setters. Could you make a PR for the updateAt property?

jmleroux commented 8 years ago

done ;)