worldia / textmaster-api

Simple PHP client for the Textmaster API
1 stars 5 forks source link

Add locale abilities api #75

Closed jmleroux closed 6 years ago

jmleroux commented 8 years ago

There is actually no documentation for this endpoint, but i need it to be able to propose only available locales.

jmleroux commented 8 years ago

Travis build failing for an unknown reason. Could you relaunch ?

jmleroux commented 8 years ago

Same random error on Travis

cdaguerre commented 8 years ago

@aponsin CI tests fail "randomly" because the sandbox is not resettable...

cdaguerre commented 8 years ago

@jmleroux The reason why we didn't implement this api method in the first place is that it's client specific (refer the client/* prefix in the uri) while the other calls of this part are public. Maybe it should be moved to a generic class containing this kind of api calls, wdyt?

aponsin commented 8 years ago

Not sure what you mean @cdaguerre regarding the "the sandbox is not resettable" ?

cdaguerre commented 8 years ago

@aponsin In order not to bloat the sandbow, we have to hardcode project ids in our functional test suites for instance. Refer https://github.com/worldia/textmaster-api/blob/master/test/Textmaster/Functional/Api/ProjectTest.php#L23 And since we have can have different runners executing our tests at the same time, they sometimes fail although they shouldn't... because of unlucky timing. If we had the ability to reset the entire sandbox, remove all previously created projects and so on, we could avoid hardcoding of project ids....

aponsin commented 8 years ago

ok, sure, let me know for which account you want to delete the projects and I can do that. But it sounds dangerous to rely on our sandbox for your test suit no ? We might reset it entirely (user accounts as well) at a future time or for an upgrade and so on.

cdaguerre commented 8 years ago

@jmleroux Pausing to wait for project launch is not a bad idea. We'll implement something like that do get around these annoying failing builds

jmleroux commented 7 years ago

The documentation for this endpoint is now online: https://fr.textmaster.com/documentation#abilities-list-abilities

jmleroux commented 6 years ago

I'm closing this PR as we will not need it anymore