worldia / textmaster-api

Simple PHP client for the Textmaster API
1 stars 5 forks source link

functional tests stabilisation #82

Closed jmleroux closed 8 years ago

jmleroux commented 8 years ago
jmleroux commented 8 years ago

Functional tests should be more stable, but some errors are still weird. Examples:

I really dunno where status canceled can come from :fearful:

Pitoune commented 8 years ago

This happens because all tests are launched in parallel. It means that the function https://github.com/worldia/textmaster-api/pull/82/files#diff-b0c9520e98f6d6806bba04206308350bR42 can be called in build for PHP 5.6 while tests in PHP 5.5 are still running. So all projects are canceled.

jmleroux commented 8 years ago

Thx @Pitoune , i understand now i will make a proposition to fix that

jmleroux commented 8 years ago

And now the tests are greenish ;)

jmleroux commented 8 years ago

No feedback ?

cdaguerre commented 8 years ago

👍 Good job