search

worldmaking / nodelab

MIT License
1 stars 2 forks source link

Three-mesh-ui multiple versions error #16

Open fOlOfw opened 2 years ago

fOlOfw commented 2 years ago

In branch ui_filiz, I'm using one of the three-mesh-ui versions; however, it is giving an multiple versions error in the console

DMGregory commented 2 years ago

I tried making a change on ui_filiz where I moved all our jsdelivr stuff to skypack.

Unfortunately, XRControllerModelFactory (used in controllers.mjs to generate the controller meshes in VR) does not seem to be available on skypack.

Leaving this one library on jsdelivr works, but it displays a warning that multiple versions of THREE.js are being imported (since XRControllerModelFactory pulls in its own).

Is there a good alternative that will let us work with both Three-Mesh-UI AND XRControllerModelFactory, where both see/use the same underlying THREE.js version?

Maybe we need to give up on using CDNs and just build our dependencies into a file that lives on our own server. It's the final week, so hopefully our dependencies are stable enough now that we know what to include?

@n1ckfg / @michaelpalumbo - any thoughts?

michaelpalumbo commented 2 years ago

sorry @DMGregory just looking at this now. I assume building our own dependencies would make for a lot of extra work down the line wrt updates etc. will return to this in a sec