worldofbalance / unity-game-client

Unity Client for World of Balance
http://smurf.sfsu.edu/~wob/
9 stars 8 forks source link

Some small refactors on the Game class #1

Closed Fito closed 8 years ago

Fito commented 8 years ago
Fito commented 8 years ago

@jensvdh could you review this change?

Fito commented 8 years ago

@jensvdh btw, I meant to branch this off of development, not master. I can manually merge it into development if you are ok with that.

jensvdh commented 8 years ago

Hey @Fito .

Can you refork off of development and make a PR of of development? Just for consistency reasons.

Also we re-discussed the whole 2 vs 4 spaces as an indentation thing. We decided on going with 4 spaces for the following reasons.

So if you can fix those remarks and make a new PR we should be able to merge into dev.

Btw, did you still see those issues with disappearing meta files?