search

worldofbalance / unity-game-client

Unity Client for World of Balance
http://smurf.sfsu.edu/~wob/
9 stars 8 forks source link

LBY - Implementation for top player and online player retrieval #17

Closed darver closed 8 years ago

darver commented 8 years ago

I added classes that make network requests and provide callbacks with the TopPlayer and CurrentlyOnline info. Left an example of the code implementation in the GameResources folder.

jensvdh commented 8 years ago

hi @darver please fix the remarks I have and push your branch to Github again to update the PR.

darver commented 8 years ago

Okay, will do

darver commented 8 years ago

It turns out the it was the preexisting code that had the tabs still in it. I made the requested changes and updated.

darver commented 8 years ago

Oh, I also took out some of the gui because @danamuise will be replacing it anyway.

jensvdh commented 8 years ago

Looks good to me. I guess the code could be optmized by sending a request to the server to return the top n players as an array instead of hardcoding the 3 top players. But that's more of an improvement.

:+1:

Feel free to merge.

darver commented 8 years ago

Cool. I can let my server guy know.