search

worldofbalance / wob-server

4 stars 6 forks source link

LBY - Minigame jar server processes not logging stderr #20

Closed rupalkhilari closed 8 years ago

rupalkhilari commented 8 years ago

Hi,

It seems like the minigame servers are only logging stdout from the processes run using 'java -jar', and not the standard error. As a result any errors thrown from the minigame servers are not showing up while running from the lobby unless they are written out to stdout.

Is it ok to display a combined log of stdout and stderr for each process so it would make it easier to debug ? I have committed a small change here (to the dev-sdv-log-minigame-err branch) which allows this and seems to be working as expected.

Please let me know if there are concerns regarding this. If not, I can create a PR for it.

Thanks.

Fito commented 8 years ago

@rupalkhilari Good catch. Make a PR and let's get it merged.

rupalkhilari commented 8 years ago

Sure, have raised PR https://github.com/worldofbalance/wob-server/pull/22 Thanks.

rupalkhilari commented 8 years ago

Thanks @anuagg for merging this.