search

worldofbalance / wob-server

4 stars 6 forks source link

Jar file cannot resolve dependency #3

Closed niculistana closed 8 years ago

niculistana commented 8 years ago

Hello guys, I uploaded a jar file under ddeb4ca it looks like the builder cannot find the ObjectPool class. I have checked the .jar file's Manifest for the Speed_Server and it looks like this:

Manifest-Version: 1.0 Ant-Version: Apache Ant 1.9.4 Created-By: 1.8.0_65-b17 (Oracle Corporation) Class-Path: lib/activation.jar lib/axis.jar lib/commons-dbcp-1.4.jar l ib/commons-discovery-0.5.jar lib/commons-logging-1.1.1.jar lib/common s-pool-1.6.jar lib/gson-2.2.2.jar lib/javax.wsdl_1.6.2.v201012040545. jar lib/jaxrpc.jar lib/json_simple-1.1.jar lib/mail.jar lib/mysql-con nector-java-5.1.22-bin.jar lib/saaj.jar X-COMMENT: Main-Class will be added automatically by build Main-Class: core.GameServer

Clearly, the ObjectPool class is there, but for some reason the builder cannot find it. If anyone could help that would be great.

\ Now, looking at the build's README for the wob-server's /dist folder, it says that:

If a library on the projects classpath also has a Class-Path element specified in the manifest,the content of the Class-Path element has to be on the projects runtime path.

I checked the runtime path and it does include lib/common s-pool-1.6.jar in WoB_Server...

niculistana commented 8 years ago

@hunvil who did the builds last year?

jan-burianek commented 8 years ago

The truth is that Apache project commons pool v1.6 is really outdated https://commons.apache.org/proper/commons-pool/ since the current version bears number 2.4.2. Although the version 1.6 is the last stable version from the 1. version branch, maybe it is not able to interact with the other dependencies.

jensvdh commented 8 years ago

image

I'm guessing this issue relates to this bug?

jensvdh commented 8 years ago

@worldofbalance/running-rhino any ideas?

haichuand commented 8 years ago

It seems like the problem was caused by repeat thread start code in MiniGame.java, line 92~101. After deleting the extra code (and the unnecessary brackets) the problem was solved for me.

jensvdh commented 8 years ago

Cool. Want to create a pull request with this fix? On Mar 29, 2016 7:39 PM, "haichuand" notifications@github.com wrote:

It seems like the problem was caused by repeat thread start code in MiniGame.java, line 92~101. After deleting the extra code (and the unnecessary brackets) the problem was solved for me.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/worldofbalance/wob-server/issues/3#issuecomment-203207363

haichuand commented 8 years ago

Sure. Which branch should I create the pull request?

niculistana commented 8 years ago

Thank you @haichuand! You can pull the https://github.com/worldofbalance/wob-server/tree/dev-rr-before-merge branch and make a commit from there. It is already on a pull request which @jensvdh is moderating.

haichuand commented 8 years ago

Just created the pull request

jensvdh commented 8 years ago

Is it #5 ?

niculistana commented 8 years ago

@jensvdh No it is not, he created a pull request for #4 which I reviewed and merged. You can see the commit under here: eed38e2080e9805d994383d9e07952b9aef20db7