issues with new json configuration format.

worldveil / dejavu

Audio fingerprinting and recognition in Python

MIT License

6.36k stars 1.43k forks source link

issues with new json configuration format. #17

Closed pguridi closed 10 years ago

pguridi commented 10 years ago

couldnt make it work with the latest changes. Would be good to have an example configuration file, with all the possible options.

How do I setup the database server credentials now?.

worldveil commented 10 years ago

The latest changes make it so that any dictionary can be handed in. So whether you read a json file and convert to dict or unpickle a dictionary, etc it's up to you.

I do agree we should probably document all the configuration options. database, with user, host,pwd and db are obviously needed. database_type is supported. What option options might we want to provide?

pguridi commented 10 years ago

I understand the advantages of the new format.., I think is simpler. But with the feature merge, a working example should be added too. Besides the format.., is the code really reading the config file?.

- What happened with the feature I pushed, for limiting the fingerprinting seconds? (It was configurable using the config file before)

are we sure this is not a regression, and dejavu is not currently broken?.

Wessie commented 10 years ago

Due to my usage of dejavu as a library more than a program I seem to indeed have regressed your limiting change.

Or better said, it isn't exposed through the command line interface. It's implemented in decoder.read and just has to be re-exposed as it was before. Exposing it without affecting library usage would be nice.