search

worldveil / dejavu

Audio fingerprinting and recognition in Python
MIT License
6.36k stars 1.43k forks source link

regression, filenames are not saved anymore with full path #20

Open pguridi opened 10 years ago

pguridi commented 10 years ago

previously [1], I pushed some changes, one of those it was adding the fullpath to the song name field in the database. (otherwise, would be imposible to match a file, if there are same names files in different folders). That change was reverted with the last merge. Is this the desired behaviour for the database? or should it be pushed again?.

[1] https://github.com/worldveil/dejavu/pull/12

Wessie commented 10 years ago

This is indeed a regression we overlooked when merging the changes. Should be easy enough to fix in a similar way as last time. Sorry for the trouble!

worldveil commented 10 years ago

Yes, agreed, will accept PR reverting.

pguridi commented 10 years ago

good. I added the fix in my fork. Also I implemented a database backend with SQLalchemy, now is much easier to switch database engines. And is helpful to have the option to use sqlite (or in memory sqlite) for writing unittests (soon I plan to write some tests).

The plain sql backend is still there, the new one is just optional. And of course, the ORM backend may need to be optimized for performance yet.

Also I added a requirements.txt to install the dependencies with pip.

Are you interested in merging this?.

pierater commented 8 years ago

I have submitted a pull request to bring path tracking back into the songs table.