Closed Wessie closed 10 years ago
So, the business with after_fork
... it is no longer needed? (and never was?).
At the very least we never called it. I was, and still am very sure it was needed (with these changes it is not needed anymore). Most likely due to lack of fingerprint_directory
usage we never noticed.
:clap:
when this gets merged Ill update my branch. for sure my changes will be much simpler now.
List of changes:
fingerprint_directory
: Now usesmultiprocessing.Pool.imap
and updates database in callers process.fingerprint_file
: Now uses_fingerprint_worker
internally._fingerprint_worker
:imap
usage.path_to_songname
: Changed to useos.path.splitext
, this caused files with a period in their name to return the wrong name.These changes should remove some of the blocks @pguridi had while implementing the SQLAlchemy backend.