Branch to support postgres backend.

worldveil / dejavu

Audio fingerprinting and recognition in Python

MIT License

6.36k stars 1.43k forks source link

Branch to support postgres backend. #78

Closed tjj5036 closed 4 years ago

worldveil commented 9 years ago

will review soon - apologies for the delay!

worldveil commented 9 years ago

All that needs to be done before merging:

We need to ensure users of a single database type to only need to install their database / corresponding python libraries for access
There are a couple changes in that fields in Database should now be inherited by PostgresDatabase (see my last commit with the merge of the SHA1 hashing for duplicate files)

Many thanks for your patience in getting review!

chubz commented 8 years ago

@worldveil is postgres isolated redo mergable, and is this feature going to be merged? Just wondering since Postgresql would be a preferable solution for a web stack solution etc.

tjj5036 commented 8 years ago

Crap I forgot about this - if there's interest I'll address the remaining comments and re-submit the PR. Any thoughts on that?

chubz commented 8 years ago

Sure, for one it would be easier to incorporate into a standard python web stack. Mostly Postgresql is used and recommended for djang/flask projects. It's a great database to use besides mysql. Also it would be easier to base further work on existing psql support by the library.

mahmoudhossam commented 7 years ago

Why only add support for postgres when we can support multiple databases using SqlAlchemy?

Alexndrrr commented 6 years ago

I agree with @mahmoudhossam -- it makes more sense to write queries in SQLalchemy and take a connection object that conforms to the DB API.

omertoptas commented 4 years ago

Anyone used this branch ? I want to try dejavu with Postgres.

mauricio-repetto commented 4 years ago

@omertoptas you can use dejavu with python 3.6.6 and postresql on the following branch https://github.com/worldveil/dejavu/pull/205