search

worldwide-asset-exchange / waxjs

Javascript API for integration with the WAX Cloud Wallet.
MIT License
126 stars 103 forks source link

Bugfix/filter unhandled popup events #64

Closed sir-barchable closed 2 years ago

sir-barchable commented 3 years ago

This fixes a race in the signing popup that results in empty signatures. Sometimes the receiveSignatures callback receives a READY event from the WaxEventSource when it can only handle TX_SIGNED events.

porkchop commented 3 years ago

Thanks @sir-barchable I am going to test this out

Farfar10 commented 2 years ago

not worked sign transaction( help bro

abdulmanan7 commented 2 years ago

This is a very serious issue, I am looking forward to this fix.

abdulmanan7 commented 2 years ago

No luck I add the changes mention in the pull request manual line by line but now it gives an error Error: User declined to sign the transaction

porkchop commented 2 years ago

Thanks a lot for this one we recently puublisghhed a refactor that fixes this issue. You should find the lkib more stable than before.