Closed a5-pickle closed 1 month ago
We have found another issue in add_auction_history_entry
. There are two parameters:
beneficiary
beneficiary_token
beneficiary
initial_offer_token
I think after changes made in this PR, beneficiary_token
is no longer needed. You can add a constraint directly on beneficiary
so it would need to be equal to auction. prepared_by
.
We have found another issue in
add_auction_history_entry
. There are two parameters:
beneficiary
- receives SOL from closed auction account
beneficiary_token
- needs to be owned by
beneficiary
- needs to be equal to
initial_offer_token
I think after changes made in this PR,
beneficiary_token
is no longer needed. You can add a constraint directly onbeneficiary
so it would need to be equal toauction. prepared_by
.
Very good catch! How does this look? https://github.com/wormhole-foundation/example-liquidity-layer/pull/193/commits/c6bd633745634f4be688aacf67c307c6a027b8c4
prepared_by
toAuction
account to save original rent payer when placing the initial offerbeneficiary
to always beprepared_by
onPreparedOrderResponse
when settling a complete auctionbeneficiary
), who will have specified which token account to send the base fee to