wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
80 stars 62 forks source link

[QA]Both wallets are disconnected after user decides to disconnect one of them after swapping places #1185

Open AigaD opened 11 months ago

AigaD commented 11 months ago

Preconditions: Solflare wallet connected at sending From section Metamask wallet connected at sending to section

Environment: MacBook Pro, macOS Ventura 13.0.1, Chrome Version 118.0.5993.88

Tested from: https://wormhole-connect.netlify.app/#

Steps:

  1. Select Solana Network at sending From section
  2. Select Base Network at sending To section
  3. Switch Networks and wallets places by clicking on Swap button
  4. Click on wallet at sending From section (should now be Metamask wallet)
  5. Click on Disconnect
  6. Observe

Actual result: When wallets are switched places and user decides to disconnect one of them, both wallets are disconnected

Expected result: Only wallet user has selected to disconnect gets disconnected

Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/0860b36e-c272-49fe-a39a-3104e3b1ea06

AigaD commented 6 months ago

Reproduced from: https://preview.portalbridge.com/b05f4e9322/# Both wallets are disconnected after swapping places even if the connected wallets are two different Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/bd866e1a-c79a-452a-b0de-64ffa5b842f1

AigaD commented 6 months ago

Tested from: https://wormhole-connect.netlify.app/# Both Phantom and Metamask wallets are disconnected after user swaps networks places

Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/2192d255-693e-43bb-aa51-e45af359d44d

tsadovska commented 2 months ago

The original scenario is reproducible on wormhole-connect-mainnet (Connect v2).

agodlevska commented 4 hours ago

Issue is still reproducible on https://portalbridge.com/ and https://wormhole-connect-mainnet.netlify.app/. When wallets are switched places and user decides to disconnect one of them, both wallets are disconnected.

Attachment:

https://github.com/user-attachments/assets/30f02752-55a0-4d14-a966-af89e54e8c04