search

wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
71 stars 48 forks source link

[QA][Mainnet] Sui Metamask Snap wallet offered when Rabby wallet is in use #1548

Open AigaD opened 5 months ago

AigaD commented 5 months ago

Preconditions: Rabby wallet is in use Console is open

Environment: MacBook Pro, macOS Ventura 13.0.1, Chrome Version 120.0.6099.234

Tested from: https://wormhole-connect-mainnet.netlify.app/# and https://preview.portal-bridge-ui.pages.dev/c0216a7edf/#

Steps:

  1. Select Sui Network
  2. Click on Connect Wallet
  3. Select Sui Metamask Snap
  4. Observe

Actual result: Sui Metamask Snap wallet is shown in the list when Rabby wallet is in use. When user tries to connect to Sui Metamask Snap wallet, error in console is shown: method [wallet_getSnaps] doesn't has corresponding handler

Expected result: If Rabby wallet is in use then Sui Metamask Snap should not be offered in wallet list the same as Metamask wallet

Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/93897443-847b-49db-b4de-744207dd67a2

AigaD commented 5 months ago

Reproduced from: https://portalbridge.com/# Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/18cfd3c3-19dc-4f50-b050-c4c154caa46c

AigaD commented 4 months ago

Tested from: https://preview.portalbridge.com/# Sui Metamask Snap is offered when Rabby wallet is in use, Sui Metamask Snap option is clickable. Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/cc7f48db-0cd7-4c8a-bccd-0d7a459e028a