wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
80 stars 62 forks source link

[QA] Not able to disconnect WalletConnect connection from Metamask mobile app #1626

Open AigaD opened 8 months ago

AigaD commented 8 months ago

Preconditions: Metamask wallet connected though WalletConnect

Environment: MacBook Pro, macOS Ventura 13.0.1, Chrome Version 121.0.6167.85 iPhone 14, iOS 16.0

Tested from: https://wormhole-connect-mainnet.netlify.app/#

Steps:

  1. Click on Connect wallet
  2. Select WalletConnect Ethereum
  3. Scan the QR code using Metamask app
  4. Observe if the connection is made
  5. Click again on the wallet
  6. Select Disconnect
  7. From Metamask app go to Settings -> Security & Privacy -> Clear Privacy data
  8. On the pop-up click Clear
  9. Return to https://wormhole-connect-mainnet.netlify.app/# and refresh the page
  10. Click on Connect wallet
  11. Select WalletConnect Ethereum
  12. Observe

Actual result: User is not able to disconnect Metamask mobile app from Wormhole-connect

Expected result: By clearing Privacy data from Metamask app, all connections should be disconnected and next connection should again ask for approval

Comments: Linking to issue: https://github.com/wormhole-foundation/wormhole-connect/issues/607

Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/81678215-8a3a-49c7-87f5-ec5a2f2c8254

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/8716eea0-3ff2-449c-b707-b377bf08f5a3

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/86a2223c-1ee3-4feb-8aa2-d550baa2d0d4

AigaD commented 4 months ago

Tested from: Mainnet Wallet is not disconnecting when user disconnects it from Metamask app Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/4327715f-1e45-42d4-b97f-33e6f234eca6

redDwarf03 commented 2 weeks ago

Perhaps it's due to wagmi ? https://1.x.wagmi.sh/react/connectors/metaMask#shimdisconnect https://github.com/MetaMask/metamask-extension/issues/10353