search

wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
81 stars 64 forks source link

[QA][Improvement] Provide matching warning messages for different networks when resuming transaction with invalid transactionId #1696

Closed AigaD closed 3 weeks ago

AigaD commented 8 months ago

Preconditions: Invalid transaction Id from Solana - 3Z3UJNdB2KgK2tVvqtMbfCS7hM6qjgQr93mN3kdmWuV7QsLpS3SrAuoMz7t54ra9FMcPYo9AsA1dMzrJw6iz8PVQ2 Invalid transaction Id from BSC - 0xb41408b00500d08a17a57ec8a42d9b2dd4a1046aa3ddbf4a58ed7482637513762

Environment: MacBook Pro, macOS Ventura 13.0.1, Chrome Version 121.0.6167.85

Tested from: https://wormhole-connect-mainnet.netlify.app/# https://preview.portalbridge.com/caab316c7d/

Steps:

  1. Click on Menu
  2. Open Resume transaction
  3. From Network drop down list select Solana
  4. Paste in the invalid transaction Id
  5. Observe warning message
  6. Copy incorrect transaction hash for BSC Network
  7. Paste the transaction Id in search window
  8. From drop down list select BSC
  9. Observe warning message

Actual result: For Solana network the warning message when transaction ID is invalid is: "Bridge transaction not found, check that you have the correct chain and transaction ID", but for BSC network when incorrect transactionId is entered warning message is: "Invalid transaction ID"

Improvement: In case incorrect transaction Id is entered show the same warning message for all Networks

Attachment:

Screenshot 2024-02-22 at 17 13 47 Screenshot 2024-02-22 at 17 13 16

agodlevska commented 2 months ago

Note: The error message is dependent on the transaction ID, not the network. Changing the provided transaction IDs for different networks will result in different errors.