search

wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
79 stars 59 forks source link

[QA] User is able to Add <token> to Metamask while transaction is still in progress #1861

Open AigaD opened 6 months ago

AigaD commented 6 months ago

Preconditions: Metamask wallet connected

Environment: OS: macOS Ventura 13.0.1 Browser: Chrome Version 121.0.6167.85

Tested from: https://preview.portalbridge.com/8228d00809/#

Steps:

  1. Prepare to send 0.01 USDC from Optimism to Base
  2. Click Approve and proceed with transaction
  3. While Confirmations are loading "Waiting for Circle attestation . . ." click on View on Wormholescan
  4. In Wormholescan scroll to the bottom of the page
  5. Click on Add to Metamask button
  6. Observe

Actual result: While transaction is still on step "Waiting for Circle attestation . . ." token is shown as added to the wallet through Wormholescan section

Expected result: User should not be able to add token to wallet, while transaction is shown as still in progress on Bridge screen

Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/d5c63193-1307-4699-842f-d26791ce91c2

AigaD commented 5 months ago

Reproduced from: https://preview.portalbridge.com/ed4e22522f/# While transaction 0.001 W from Solana (Solflare) to Base (Metamask) manual Native token transfer route, is still in progress user is able to "Add to Metamask" through Wormholescan Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/fdc51f9b-d3cf-4b4d-aa17-a241e48019fd

agodlevska commented 1 month ago

Issue is still reproducible on https://portalbridge.com/. During "Waiting for Circle attestation . . ." step, it is possible to add token to the MetaMask through WHS.

Attachment:

https://github.com/user-attachments/assets/f7cf4e12-0d47-4571-955b-94780ca8bd87