search

wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
77 stars 56 forks source link

[QA] [Mainnet] Arbitrum explorer link leads to invalid transaction hash result #1909

Open tsadovska opened 4 months ago

tsadovska commented 4 months ago

Describe the current behavior in detail

Checked on https://wormhole-connect-mainnet.netlify.app/ [Mainnet] with macOS and Google Chrome.

Steps:

  1. Prepare to send 0.001 wstETH (Optimism) from Optimism (MetaMask) to Arbitrum (MetaMask)
  2. Click "Approve and proceed with transaction" button
  3. Click on "Arbitrum Explorer" link

Actual result: Arbitrum explorer link opens result "Oops! An invalid Txn hash has been entered: 69235afe48783af90f4d31c50efdc880da86d1993fc86acbb0557936de942a2b". Link https://arbiscan.io/tx/69235afe48783af90f4d31c50efdc880da86d1993fc86acbb0557936de942a2b

Correct link is https://arbiscan.io/tx/0x69235afe48783af90f4d31c50efdc880da86d1993fc86acbb0557936de942a2b

Error:

 Error: invalid hash (argument="value", value="69235afe48783af90f4d31c50efdc880da86d1993fc86acbb0557936de942a2b", code=INVALID_ARGUMENT, version=providers/5.7.2)
    at Logger.makeError (/assets/main-BIApWWvg.js:166:46729)
    at Logger.throwError (/assets/main-BIApWWvg.js:166:46862)
    at Logger.throwArgumentError (/assets/main-BIApWWvg.js:166:46923)
    at Formatter.hex (/assets/main-BIApWWvg.js:172:74447)
    at Formatter.hash (/assets/main-BIApWWvg.js:172:75118)
    at StaticJsonRpcProvider.<anonymous> (/assets/main-BIApWWvg.js:172:108186)
    at Generator.next (<anonymous>)
    at Hn (/assets/main-BIApWWvg.js:172:79192)

image

https://github.com/wormhole-foundation/wormhole-connect/assets/10746654/2b10d01e-7935-4bed-aec4-0356c136210c

What is the expected/desired behavior

Link to "Arbitrum explorer" opens transaction details page.

tsadovska commented 4 months ago

Issue is reproducible on https://wormhole-connect-mainnet.netlify.app/ when sending 0.0003 wstETH (Optimism) from Optimism (MetaMask) to Arbitrum (MetaMask).

Arbitrum explorer link opens result "Oops! An invalid Txn hash has been entered: 73c013ff53226ea3436ad9f56799ca00b845653f2bf6f08bd5a4d349fe73d286" https://arbiscan.io/tx/73c013ff53226ea3436ad9f56799ca00b845653f2bf6f08bd5a4d349fe73d286 instead of https://arbiscan.io/tx/0x73c013ff53226ea3436ad9f56799ca00b845653f2bf6f08bd5a4d349fe73d286.

Send from tx: https://optimistic.etherscan.io/tx/0x2164fd439409672f8dc37fa09199612fc1730b03fa2c57b9b351c16c039e8bb6 Link to Wormholescan: https://wormholescan.io/#/tx/0x2164fd439409672f8dc37fa09199612fc1730b03fa2c57b9b351c16c039e8bb6

kev1n-peters commented 4 months ago

Think this happens when the TX hash is fetched from wormholescan and is not normalized with the 0x prefix

tsadovska commented 3 months ago

Reproducible on https://deploy-preview-2143--wormhole-connect-mainnet.netlify.app/ [Mainnet] when sending 0.0015 ETH from Ethereum (MetaMask) to Arbitrum (MetaMask).

tsadovska commented 2 months ago

Reproducible on https://preview.portalbridge.com/2c6f665417/ [Mainnet] when sending 0.0001 WETH (Polygon) from Polygon (MetaMask) to Arbitrum (MetaMask).

agodlevska commented 2 months ago

Reproducible on https://preview.portalbridge.com/8b6491733c/ [Mainnet] when sending 0.001 ETH (Ethereum) from Ethereum (MetaMask) to Arbitrum (MetaMask).

agodlevska commented 1 month ago

Reproducible on https://preview.portalbridge.com/3365c86aff/ when sending 1 USDT from Optimism (MetaMask) to Arbitrum (MetaMask).

agodlevska commented 6 days ago

Reproducible on https://preview.portalbridge.com/b3b7091778/ when sending 0.0001 ETH from Ethereum (MetaMask) to Arbitrum (MetaMask).