search

wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
78 stars 58 forks source link

[Bug] WalletConnect popup shows up unprompted #2671

Open tonyjin opened 1 week ago

tonyjin commented 1 week ago

Description and context

WalletConnect popup shows up unprompted when WalletConnect is selected as the wallet option for a chain, but before "Connect source wallet" button is clicked.

Steps to reproduce

  1. Load Connect V2 on Portal
  2. Choose source chain/token, select Ethereum
  3. Connect source wallet, select WalletConnect, but do not choose an option or connect via QR
  4. Reload page
  5. Choose source chain/token
  6. Note that WalletConnect popup shows up beneath the source chain/token popup automatically

Note: This does not appear to be consistently reproducible even with the steps above. It seems like if the localstorage propertywormhole-connect:wallet:Ethereum is set to WalletConnect, this will occur.

Experienced behavior

WalletConnect popup appears unexpectedly

Expected behavior

WalletConnect popup should not appear until "Connect source wallet" button is clicked.

Attached screen recording: https://github.com/user-attachments/assets/0caa2a1e-3e97-4fc1-aac7-b55395335276

sebastianscatularo commented 1 week ago

should be fixed once https://github.com/wormhole-foundation/wormhole-connect/pull/2686 gets merged

emreboga commented 1 week ago

I can confirm that I don't see the issue after the above PR is merged. @tonyjin you wanna double-check?

tonyjin commented 6 days ago

I wasn't able to reliably reproduce the issue originally, but I also could not reproduce it in the development build post-merging of 2686.