wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
81 stars 64 forks source link

[QA] An unexpected notification to switch network is displayed in MetaMask mobile app #2795

Open tsadovska opened 1 month ago

tsadovska commented 1 month ago

Describe the current behavior in detail

Checked on https://wormhole-connect-mainnet.netlify.app/.

Devices:

Steps:

  1. Open MetaMask mobile app
  2. Open https://wormhole-connect-mainnet.netlify.app/ in Desktop browser
  3. Select BSC network and BNB token in "From" section
  4. Select Ethereum network and WBNB token in "To" section
  5. Click on "Connect source wallet" button and select WalletConnect option (Wallet is auto-connected)
  6. Click on "Connect destination wallet" button and select WalletConnect option (Wallet is auto-connected)
  7. Enter Amount, in my case 0.0001
  8. Click on "Review transaction" button
  9. Click on "Confirm transaction" button
  10. Check notification in MetaMask mobile app

Actual result: Notification to switch network to Avalanche is shown. Expected result: Notification to switch network is not shown, because correct chain is already selected in MetaMask mobile app.

Notes/ Attachments

Issue is reproducible only when wallets are automatically connected in Steps 5 and 6. When user needs to scan a QR Code in Step 5, notification to switch network is not displayed.

https://github.com/user-attachments/assets/50e0e78a-cd12-4bde-985a-f390a54d7a2d

emreboga commented 1 month ago

@tsadovska I wasn't able to reproduce this. My MetaMask wallet on mobile device is not asking to switch network to Avalanche. Can you please double-check?

tsadovska commented 1 month ago

@emreboga Rechecked the issue on Oct 16. Unexpected notification to switch network to Ethereum is shown on mobile when user starts transfer from BSC network.

Preconditions: "BNB Smart Chain" is not added to the list of Networks in MetaMask app.

Steps:

  1. Fantom network is selected in MetaMask mobile app
  2. Select BSC network and BNB token in "From" section
  3. Select Ethereum network and WBNB token in "To" section
  4. Click on "Connect source wallet" button and select WalletConnect option (Wallet is auto-connected)
  5. Click on "Connect destination wallet" button and select WalletConnect option (Wallet is auto-connected)
  6. Click on "Review transaction" button
  7. Click on "Confirm transaction" button
  8. Enter Amount, in my case 0.0001
  9. Click on "Review transaction" button
  10. Click on "Confirm transaction" button
  11. Confirm notification to add "BNB Smart Chain" in MetaMask mobile app
  12. Click on "Switch network" button to change network to "BNB Smart Chain"
  13. Check the notification that appears next

Actual result: Notification to change network to Ethereum is shown.

Checked with iPhone 11 Pro iOS 17.6.1 and MetaMask v7.31.1 (1449), and macOS Sonoma 14.5 and Google Chrome Version 129.0.6668.100 (Official Build) (arm64).

https://github.com/user-attachments/assets/c17ac14f-6071-46e3-be8a-cb3c5ad352c5

tsadovska commented 2 weeks ago

Reproduced on Netlify with following scenario:

  1. BNB network was selected in MetaMask mobile app
  2. Prepared to send 0.0001 USDC from Base to Arbitum (wallets were auto-connected)
  3. Click on "Review transaction" button and "Confirm transaction" buttons
  4. Confirm notification to switch network to Base
  5. Check if one more notification to switch network is displayed

Actual result: Notification to switch network to BNB is displayed.

https://github.com/user-attachments/assets/a2a53d09-96cc-451b-ae28-368d719046d8