wormhole-foundation / wormhole-connect

Wormhole Connect brings all the functionality and utility of Wormhole right into your application and removes all of the complexity.
https://connect-in-style.wormhole.com/
Other
79 stars 59 forks source link

[QA] Improvement: User should be informed that amount should be increased to proceed the transaction #652

Closed tsadovska closed 11 months ago

tsadovska commented 1 year ago

Build:

https://feature-sei--wormhole-connect.netlify.app/ [Testnet]

Steps:

  1. Connect Metamask wallet in From section
  2. Connect Keplr wallet in To section
  3. Prepare to send ETH from Goerli to Sei
  4. Type too small amount, in my case 0.0000000000000000001
  5. Click “Approve and proceed with transaction” button

Actual result:

Error is displayed in Console:

Error: invalid decimal value (argument="value", value="1e-19", code=INVALID_ARGUMENT, version=bignumber/5.7.0)
    at f.makeError (index.ts:269:28)
    at f.throwError (index.ts:281:20)
    at f.throwArgumentError (index.ts:285:21)
    at h (fixednumber.ts:76:16)
    at Module.c (index.ts:80:12)
    at index.ts:165:21
    at Object.onClick (Send.tsx:109:26)

Expected result:

User should be informed that the amount should be increased to proceed the transaction.

Device:

MacBook Pro, macOS Monterey 12.6.5, Chrome Version 113.0.5672.126 (Official Build) (x86_64)

Attachment:

Screenshot 2023-05-30 at 13 24 43

AigaD commented 1 year ago

This is also reproduced on Mainnet - https://mainnet--wormhole-connect.netlify.app/# Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/fe445793-4aff-42a7-a6aa-3f1c643d9b9c

Screenshot 2023-06-28 at 09 32 39
tsadovska commented 1 year ago

Reproduced on https://mainnet--wormhole-connect.netlify.app/ [Mainnet] when sending 0.00000000000000001 WFTM from Base (Metamask) to Sui (Nightly). Error in Console:

Error: invalid decimal value (argument="value", value="1e-17", code=INVALID_ARGUMENT, version=bignumber/5.7.0)
    at l.makeError (index.ts:269:28)
    at l.throwError (index.ts:281:20)
    at l.throwArgumentError (index.ts:285:21)
    at h (fixednumber.ts:76:16)
    at Module.c (index.ts:80:12)
    at index.ts:165:21
    at Object.onClick (Send.tsx:104:26)
tsadovska commented 1 year ago

Issue is reproducible on https://wormhole-connect.netlify.app/ [Testnet] when sending assets to :

tsadovska commented 1 year ago

Issue is reproducible on https://feat-cosmos-gateways--wormhole-connect.netlify.app/ [Testnet] when sending 9e-8 from Osmosis (Leap) to Goerli (Metamask).

image

AigaD commented 11 months ago

Tested OK. User can no longer type in more than 7 digits after comma in the amount section. Tested from: https://wormhole-connect.netlify.app/# and https://wormhole-connect-mainnet.netlify.app/# Improvement regarding showing small amounts that is being sent, reported here: https://github.com/wormhole-foundation/wormhole-connect/issues/1023

Attachment:

https://github.com/wormhole-foundation/wormhole-connect/assets/91047061/5e6d1cda-e0b5-4a87-a35f-45b1f98e4fb4