search

wormhole-foundation / wormhole-scaffolding

Starter apps with Wormhole integration
Other
47 stars 30 forks source link

solana: Makefile implicitly requires a version of git newer than 2.25 #48

Closed barnjamin closed 1 year ago

barnjamin commented 1 year ago

The command to checkout wormhole from GitHub results in the following output (run manually here)

~/wormhole-scaffolding/solana/dependencies$ git clone --depth 1 --branch main --filter=blob:none  --sparse  https://github.com/wormhole-foundation/wormhole tmp-wormhole 
Cloning into 'tmp-wormhole'...
fatal: cannot change to 'https://github.com/wormhole-foundation/wormhole': No such file or directory
error: failed to initialize sparse-checkout

This appears to be a bug related to the --sparse flag fixed with this commit in git core: https://github.com/git/git/commit/47dbf10d8a5ce8c9b441a16b7698c7d70585dff0

Ubuntu 20.04 default package manage only provides up to git v2.25.1 so an alternate PPA must be used to install a later version which does work.

What do? Omit --sparse if we find git --version <= 2.25.1? Give a better error message?

a5-pickle commented 1 year ago

Good find. I think we should change the command to fetch differently to avoid this --sparse keyword entirely