wormhole-foundation / wormhole

A reference implementation for the Wormhole blockchain interoperability protocol.
https://wormhole.com
Other
1.68k stars 690 forks source link

npm not found in solana-devnet base image #1871

Closed antonio-altr closed 1 year ago

antonio-altr commented 2 years ago

Github issues are ONLY for reporting bugs. Before contributing new features (such as a new chain) please first read the contribution frequently asked questions.

For user support questions such as VAA not found, please use the Wormhole Official Discord. Do not give your wallet private key or mnemonic words to anyone.

Expected Behavior

I'm launching a devnet with a Solana node as described here. Without Solana everything works as expected.

Current Behavior

With Solana, I get this error:

solana-devnet │      [solana  4/14] RUN --mount=type=cache,target=/root/.cache     cargo install --version =2.0.12 --locked spl-token-cli [done: 3m57.492s]
solana-devnet │      [solana  5/14] WORKDIR /usr/src/clients/js
solana-devnet │      [solana  5/14] WORKDIR /usr/src/clients/js [done: 44ms]
solana-devnet │      [solana  6/14] COPY clients/js/package.json clients/js/package-lock.json ./
solana-devnet │      [solana  6/14] COPY clients/js/package.json clients/js/package-lock.json ./ [done: 46ms]
solana-devnet │      [solana  7/14] RUN --mount=type=cache,uid=1000,gid=1000,target=/home/node/.npm     npm ci
solana-devnet │        → /bin/sh: 1: npm: not found
solana-devnet │      
solana-devnet │      ERROR IN: [solana  7/14] RUN --mount=type=cache,uid=1000,gid=1000,target=/home/node/.npm     npm ci
solana-devnet │
solana-devnet │ ERROR: Build Failed: ImageBuild: executor failed running [/bin/sh -c npm ci]: exit code: 127

Possible Solution

That error is for this line: https://github.com/wormhole-foundation/wormhole/blob/51eac5104c1b204b0748cae4abeddec68664ec9e/Dockerfile.client#L14

I think the base image does not have npm so it should be updated.

Steps to Reproduce

  1. tilt up -- --solana=true

Context (Environment)

Issue observed on fresh Ubuntu 20.04 with all the devnet required tools (minikube, Docker, etc) installed.

Detailed Description

Possible Implementation

evan-gray commented 1 year ago

Hi @antonio-altr - I wasn't able to reproduce this with latest dev.v2 (https://github.com/wormhole-foundation/wormhole/commit/6de97de242e57be4a0a8a0840f5a16bf4cd55bda) on the following system:

Could you provide any additional details?

aadam-10 commented 1 year ago

Please reopen with the information