Closed coolstar closed 10 months ago
Will do a followup PR to switch all the drivers over to READ_REGISTER_ULONG / WRITE_REGISTER_ULONG
The driver binary is not part of the artifact. Does it build to the same location as the other drivers?
Source\Utilities\pl330dma.h
could be moved to drivers\include
since it may be used by other drivers. It's also missing include guards.
Can you rename the device desc to "Rockchip I2S Controller" for consistency?
Not a fan of the multiple vcxprojs TBH, the files could be all included in the base project without changing the directory structure (which you said you care about).
Looks good to me otherwise. Great work!
Will do a followup PR to switch all the drivers over to READ_REGISTER_ULONG / WRITE_REGISTER_ULONG
If you're concerned about performance, you can consider READ_REGISTER_NOFENCE_ULONG
.
op_REGISTER_ULONG
:
dsb 0xF
to do a "full-system data sync barrier". This also ldr
or str
instruction, no optimizations allowed (compiler is not allowed to move the instruction above or below other REGISTER instructions and is not allowed to load more than once or store more than once).op_REGISTER_ULONG_NOFENCE
:
op_REGISTER_ULONG
except without the dsb
.My understanding is that in most cases, op_REGISTER_ULONG_NOFENCE
is sufficient. Though honestly, I'm a bit unclear about when you actually need the dsb
, as it doesn't seem to do a lot of good in the cases I've considered (i.e. by itself it doesn't flush cache so it doesn't fix DMA).
- The driver binary is not part of the artifact. Does it build to the same location as the other drivers?
Might have been missing as the package was removed (fixed this), as the output location was correct
Source\Utilities\pl330dma.h
could be moved todrivers\include
since it may be used by other drivers. It's also missing include guards.
Done
- Can you rename the device desc to "Rockchip I2S Controller" for consistency?
Done
- Not a fan of the multiple vcxprojs TBH, the files could be all included in the base project without changing the directory structure (which you said you care about).
Could look into this for a follow-up PR
Looks good to me otherwise. Great work!
Add I2S Audio driver. Reads ACPI properties from the bus driver to enumerate audio endpoints.
Supports:
Supported, but untested:
Notes: