search

worstcase / blockade

Docker-based utility for testing network failures and partitions in distributed applications
http://blockade.readthedocs.org
Apache License 2.0
907 stars 72 forks source link

fix links of named containers #34

Closed kongo2002 closed 8 years ago

kongo2002 commented 8 years ago

Hi,

this changeset fixes links between containers with overridden names (via container_name).

Moreover I added a minor change to the invocation of the tc command, in order to use the vimagick/iptables docker image instead of the rather heavy ubuntu one.

Cheers, Gregor

labisso commented 8 years ago

Thanks for another contribution! This looks good, but I'm having trouble setting "slow" mode.

Problem running Blockade command 'tc qdisc replace dev vethe5064ea root netem delay 75ms 100ms distribution normal': No distribution data for normal (/lib/tc//normal.dist: No such file or directory)

Perhaps this tc installation is somewhat different? Or maybe we just need a different tc command string. If you don't have any ideas, I can investigate more soon.

kongo2002 commented 8 years ago

Yes, you are right - I am seeing the same problem. I obviously missed to test the slow command explicitly :(

kongo2002 commented 8 years ago

It looks like this is a packaging problem. tc searches in the wrong directory /lib/tc while the distribution files are located in /usr/lib/tc.

kongo2002 commented 8 years ago

Maybe we can fix this in the vimagick/iptables docker image at first (see https://github.com/vimagick/dockerfiles/pull/25).

Alternatively we could also strip out the distribution ... from the tc command...

labisso commented 8 years ago

Nice.. looks like that PR got merged, but I'm still seeing the issue. I'm fine with removing the distribution component if that fixes it.

kongo2002 commented 8 years ago

I guess we still have to wait a bit for docker hub to build the updated docker image. As of now it still seems to be queued: https://hub.docker.com/r/vimagick/iptables/builds/

labisso commented 8 years ago

ahh ok. I just saw that docker pull got me a new image so I assumed it was this one

kongo2002 commented 8 years ago

You can try again if you like - it works for me now :-)

labisso commented 8 years ago

Yep looks good now. Thanks!