Closed wintermeyer closed 1 year ago
It might be a good idea to move everything (except the friendly_id) into a namespace, as originally proposed. Such as /intern
or /app
. That would simplify the routes quite a bit.
Something like:
namespace :intern do
resource :search, only: :show
resource :page, only: :show
end
Ideally, that namespace doesn't exist in German. Could also just be a letter, such as /i
or /s
. We can put that into the initializer of friendly_id as config.reserved_words
, so that it doesn't generate slugs for that identifier.
We have to take care with the German URLs that the code doesn't get too complex and that we don't let German vocabulary drip into the code base. That is, the Rails controller should ideally be called SearchesController
and not SucheController
.
It might be a good idea to move everything (except the friendly_id) into a namespace, as originally proposed.
👍
Ideally, that namespace doesn't exist in German.
I disagree with that. I propose we use /seite
. That is a word most can somehow understand. /intern
doesn't make sense for all pages. /app
is not German and we are dealing with a German audience. But in the worst case I can live with /app
but I prefer /seite
.
We have to take care with the German URLs that the code doesn't get too complex and that we don't let German vocabulary drip into the code base. That is, the Rails controller should ideally be called
SearchesController
and notSucheController
.
👍
I am only talking about the route paths. Not about the actual code.
Could become obsolete because of https://github.com/wort-schule/wort.schule/issues/67
I think we still need the power search site, which enables you to search for everything you ever dreamed of as a German teacher.
I think we still need the power search site
You can't have your cake and eat it too. Our current goal is an easy to use GUI. Most of our users are not power users. We have to find a way to make them happy. The current power search scares most users.
With a bit of luck and UX magic we find a solution without having to provide an extra search page. Let’s try that first. If we can’t find a good solution we’ll add an extra power search page.
For now, I moved everything below a scope /seite
. For example, we now have /seite/search
, /seite/nouns
, /seite/schools
, etc. The idea is that everything application related is "below" /seite/...
. Only the word URLs such as /adler
remain at the top level.
This issue is about renaming /search
to /suche
though. Do we still want to rename that?
If we do rename it, shouldn't we then also rename all other routes? For example, /seite/substantive
instead of /seite/nouns
.
I'm looking for consistency: I'd vote either to change all of the routes into German or none of them. Translating them into German will be a small pain technically and we can't translate all of them (Devise, ActiveStorage, etc.).
But maybe that whole discussion is obsolete because of #67.
@wintermeyer What do you think?
This issue is about renaming
/search
to/suche
though. Do we still want to rename that?
Yes.
If we do rename it, shouldn't we then also rename all other routes? For example,
/seite/substantive
instead of/seite/nouns
.
Those pages are goner anyway. With the new idea of how we search those pages will not be needed any more.
But maybe that whole discussion is obsolete because of #67.
It is kind of obsolete.
I close this issue for now. We'll wait for the outcome of #67
The problems with https://wort.schule/search:
suche
Task
Addseite
to forbidden slugs for friendly IDAdd migration to change existing slugseite
to something else (if that exists)