search

worthbak / inventory-checker-app

A macOS app for checking Apple Store inventory
https://worthbak.github.io/inventory-checker-app/
GNU General Public License v3.0
115 stars 24 forks source link

Add more countries #31

Closed theontho closed 2 years ago

theontho commented 2 years ago

Fix #15 (japan) Fix #27 (also japan) Fix #16 (china) Fix #26 (singapore) Fix #1 (austria)

Add taiwan, netherlands Try to add Brazil

perondeau commented 2 years ago

Can you add support for France ?

worthbak commented 2 years ago

Apologies for leaving this PR open for so long. The difficulty with adding new countries is that the more countries I add, the harder it is to update the app to support new products (for example, adding the Apple Watch Ultra took quite some time because Apple chose to give the Ultra slightly different model-number variations for many countries, requiring me to check them all).

That said, I would like to add more countries, but will need to do so slowly. Your PR doesn't account for some regional variations in existing products (namely the iPhone, iPad, and now the Watch), so I'm going to close it. If I come up with a better way for community members to contribute country-specific data in the future, then I hope you'll contribute!