search

worthmine / Text-vCard-Precisely

Read, Write or Edit vCard 3.0 or 4.0 with perl
https://metacpan.org/pod/Text::vCard::Precisely
Other
3 stars 3 forks source link

Valid phone number not accepted #5

Closed abraxxa closed 4 years ago

abraxxa commented 4 years ago

The valid format is +12 345 6789 0123 which is one digit longer than what is currently accepted by your module.

worthmine commented 4 years ago

thank you for reporting. I have fixed it so please check it.

The next release will be after that #6 is fixed.

worthmine commented 4 years ago

@abraxxa , May I close this issue?

abraxxa commented 4 years ago

Sorry for the late reply. I've checked version 0.17 but some valid phone number are still not accepted. The country code may be three digits long: https://en.wikipedia.org/wiki/Telephone_numbers_in_Slovakia

And the phone number might be longer as well. Maybe you shouldn't validate them so strictly at all of use a module that does this well as it's quite complex.

worthmine commented 4 years ago

I agree with you.

worthmine commented 4 years ago

On version 0.18, I give up to validate phone numbers