wose / satnogs-monitor

Terminal UI monitor for your SatNOGS ground station.
GNU General Public License v3.0
78 stars 6 forks source link

Support rotor performing a reset where no position is returned #23

Closed wnagele closed 4 years ago

wnagele commented 4 years ago

I noticed that the rotor position would stop to refresh as soon as a reset (to zero the positions for elevation and azimuth) was performed.

This is because during the reset no position is returned for a p query. Instead a RPRT error is returned, in a single line result instead of two lines for elevation and azimuth. Included is a simple workaround for this problem by returning -1 degrees for both elevation and azimuth during the reset.

I am sure there are better ways to signal this problem all the way up to the UI, but I do not have the in-depth knowledge of the code to do this.

wose commented 4 years ago

HI,

thx for the contribution. I'll merge this for now and take a more closer look on how to handle rotator faults when I have a little bit more time.

Cheers