search

wotwot / pdsh

Automatically exported from code.google.com/p/pdsh
GNU General Public License v2.0
0 stars 0 forks source link

Patch to add SLURM partition support to pdsh slurm module #53

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I frequently find it useful to target all the nodes in a slurm partition with 
soem command.  To enable this, I wrote a patch to the pdsh slurm module that 
uses the slurm C API to retrieve a list of all the nodes in a partition (very 
similar to what the existing -j option does).  I've attached the patch in case 
you'd like to add it to the mainline.

Original issue reported on code.google.com by michaelf...@gmail.com on 25 Oct 2012 at 2:07

Attachments:

GoogleCodeExporter commented 9 years ago 
Nice work, you even added a test.
My only comment would be to use -P not -p which conflicts with pdcp option.
(I don't think -P conflicts with anything but I did not check)

If you make that change I'll include your patch.

Thanks!
mark

Original comment by mark.gro...@gmail.com on 25 Oct 2012 at 4:07

GoogleCodeExporter commented 9 years ago 
No problem, here's the patch with the change.  I also added a bit to the man 
page documenting -P.

Original comment by michaelf...@gmail.com on 26 Oct 2012 at 3:52

Attachments:

GoogleCodeExporter commented 9 years ago 
Just checking in on this.

Original comment by michaelf...@gmail.com on 6 Nov 2012 at 2:45

GoogleCodeExporter commented 9 years ago 
Sorry, I applied your patch to my local git tree, but ran into
problems when running ./bootstrap.

I don't think the check for slurm_load_partitions is strictly necessary
at this time. OK if I remove it, and thus forgo re-run of ./bootstrap for
now?

Original comment by mark.gro...@gmail.com on 16 Nov 2012 at 10:16

GoogleCodeExporter commented 9 years ago 
That's fine.  If slurm_load_jobs is available, then slurm_load_partitions 
almost certainly is as well.

Original comment by michaelf...@gmail.com on 16 Nov 2012 at 10:41

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision c71ef9c13a97.

Original comment by mark.gro...@gmail.com on 19 Nov 2012 at 7:02