Fix some small issues - Githubissues

woutdp / live_svelte

Svelte inside Phoenix LiveView with seamless end-to-end reactivity

https://hexdocs.pm/live_svelte

MIT License

1.01k stars 38 forks source link

Closed vonagam closed 11 months ago

vonagam commented 11 months ago

json and liveJsonData variables in getLiveJsonProps were missing declaration specifier. The code was not working in strict mode.
Svelte was complaining about compilerOptions.css being boolean in the client config, set it to corresponding proper string value - injected.
hydrate should be true only if there was ssr involved, was getting errors about it, added data-ssr attribute to indicate server rendering.
other stuff is just cosmetics, making things consistent.

vonagam commented 11 months ago

In LiveSvelte.Components.get_svelte_components do not do search subdirectories since currently only top level svelte components are actually supported (in name_to_function there is no expectation for name to include a directory, only a basename is used, meaning that component name prop will be wrong as it should include a full path), also removes need to filter out _build folder. Can undo this change and add support for nested ones, it will expect that all components should have different basenames.

woutdp commented 11 months ago

Thanks for the changes/fixes!

The get_svelte_components function has an error in it though, fn doesn't end with end. The other changes look good :)

vonagam commented 11 months ago

Added end.

woutdp commented 11 months ago

Available in version 0.10.1