Clean up render.js - Githubissues

woutdp / live_svelte

Svelte inside Phoenix LiveView with seamless end-to-end reactivity

https://hexdocs.pm/live_svelte

MIT License

1.01k stars 38 forks source link

Closed vonagam closed 11 months ago

vonagam commented 11 months ago

Currently props and slots are always passed from server side so no need for default values, they are never applied.
There should be no need to delete require.cache because elixir-nodejs does it already on every call.
Object.fromEntries will always return an object so || {} is not needed after the call.
context is already new Map() by default so can be removed from options.

woutdp commented 11 months ago

Great improvement! I remember needing the delete require.cache code before but it seems to work without it now :)