Closed rtm2017 closed 3 years ago
@rtm2017 Did this only happen the one time? "504 - Gateway Timeout" sounds like it would be something on the locast end where their web server is having a problem reaching something on the back end. I get this with nginx when using reverse proxy and one the services behind it is down.
@wouterdebie I'm not sure whether this is worth adding some kind of retry behavior to mitigate against.
Right now the http client retries recoverable errors, but a 504 is considered serious, so it won't retry. What I could do though is to try again until we run out of chunks to serve and then just stop the stream.
On Sun, Apr 18, 2021, 11:11 Roddie Hasan @.***> wrote:
@rtm2017 https://github.com/rtm2017 Did this only happen the one time? "504 - Gateway Timeout" sounds like it would be something on the locast end where their web server is having a problem reaching something on the back end. I get this with nginx when using reverse proxy and one the services behind it is down.
@wouterdebie https://github.com/wouterdebie I'm not sure whether this is worth adding some kind of retry behavior to mitigate against.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wouterdebie/locast2tuner/issues/40#issuecomment-822016679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKABSJ3WTRKN7RIKI5EJLTJMAB7ANCNFSM43D3PENQ .
I've only seen it this one time. I'm not even sure it was streaming anything when it happened, I just logged in and saw that the docker container had stopped. I would expect that if locast was down or connection to the internet was lost the docker container would continue to run and simply retry
Yeah, this should not result in a panic, but locast2tuner should either silently ignore this and stop the stream or retry.
On Sun, Apr 18, 2021 at 1:30 PM rtm2017 @.***> wrote:
I've only seen it this one time. I'm not even sure it was streaming anything when it happened, I just logged in and saw that the docker container had stopped. I would expect that if locast was down or connection to the internet was lost the docker container would continue to run and simply retry every 5 minutes or something
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wouterdebie/locast2tuner/issues/40#issuecomment-822038284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKABWNA3ZWMFGBTJE7GWTTJMQM7ANCNFSM43D3PENQ .
I chose to just stop the stream, rather than retrying. I think this is a nice solution, since locast2tuner doesn't panic and exit, but the stream is just gone. With errors like this, we have no idea when it comes back, and we only have a 10 segment window to recover before the stream pretty much craps out. I just pushed a fix for this and should be available in 0.1.26 (currently building and available in 15 mins or so). Thanks for the bug report!
Closing this issue for now, since this should not happen anymore. Let me know when something similar does happen :)
Noticed my Docker container had stopped. Thought I would grab the log Unraid: 6.9.1 locast2tuner: 0.1.25
I would have expected locast2tuner to retry instead of stopping.
Let me know what else I can provide to help solve this!