search

wouterdebie / locast2tuner

Locast to Emby/Plex/Channels server
https://wouterdebie.github.io/locast2tuner/
MIT License
52 stars 8 forks source link

Panic due to missing field "showType" #49

Closed scotte closed 3 years ago

scotte commented 3 years ago

I had a crash in locast2tuner where it looks like the parser could use a little more resilience and permissiveness in parsing:

locast2tuner[14701]: thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Decode, source: Error("missing field `showType`", line: 1, column: 3543309) }', src/service/mod.rs:333:10
locast2tuner[14701]: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
systemd[1]: locast2tuner.service: Main process exited, code=killed, status=6/ABRT
systemd[1]: locast2tuner.service: Failed with result 'signal'.

I have no idea about the data that failed parsing except that locast2plex didn't crash when I switched back to it - however I also got locked out of locast for a bit (my systemd unit retry after crash was too agressive at 30 seconds) so I can't guarantee the bad data was still there by the time I switched back.

scotte commented 3 years ago

Whoops, should have checked BEFORE creating this issue that it was already reported and since resolved. Sorry about that!