wouterdebie / locast2tuner

Locast to Emby/Plex/Channels server
https://wouterdebie.github.io/locast2tuner/
MIT License
52 stars 8 forks source link

Mapping changed #78

Closed johnluber closed 3 years ago

johnluber commented 3 years ago

Describe the bug

I use l2t in alongside Channels-DVR and I'm leveraging the multiplex feature to bring in 3 zip codes (Baltimore, Raleigh, and Tampa Bay). I also use a remap.json file to change channel numbers to be unique since there is overlap between these markets and my own local market. In this setup I was able to easily identify the guide data within channels to map it to the new channels based on the guide name. For example, (I apologize but this is from memory) I would map 7002.1 to ABC Baltimore.

In a recent change, perhaps since yesterday, the Baltimore designation is no longer available and so the guide mapping broke.

As a workaround, I've edited remap.json to add the city to remap_call_sign. Previously, this was not necessary.

Channels developers change code frequently and I also saw that l2t updated to 1.50 so I'm not 100% certain where the problem lies. I suspect this is more related to 1.50 than Channels-DVR though.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Logs

No erros were logged but the guide had no data for the l2t channels as a result.

Configuration

logfile = "/var/log/locast2tuner/locast2tuner.log" remap_file = "/etc/locast2tuner/remap.json" bind_address = "0.0.0.0" cache_directory = "/var/lib/locast2tuner" cache_timeout = 3600 days = 8 device_firmware = "hdhomerun3_atsc" device_model = "HDHR3-US" device_version = "20170612" disable_station_cache = false multiplex = true override_zipcodes = ["27587", "21227", "33559"] password = "***" port = 6077 quiet = false remap = false rust_backtrace = false syslog = false tuner_count = 3 username = "my_email_address" verbose = 0 Environment What operating system and version you are using.

Screenshots

Screen Shot 2021-08-13 at 2 47 14 PM

This screenshot is after my workaround. I don't have one from prior but it would show one less instance of the city in each column. So, city would appear in the left column once and not at all in the right. Note: this shot is from Channels-DVR.

Environment

Ubuntu 20.04

Additional context Add any other context about the problem here.

wouterdebie commented 3 years ago

Hey! Could it be because of afcc2062? this added a gracenote id to tuner.m3u. I don't use channels myself, so I have a heard time testing this. Can you check if the output of tuner.m3u looks sane? As well as epg.xml? Also, would you be able to revert to a pre 0.1.50 version and see if that makes a difference?

johnluber commented 3 years ago

Ok, could be. I reverted my changes to the remap.json and then reinstalled 1.48 which was the previous I had. After do this everything looks fine again.

Here's a screenshot showing the mapping in Channels and the guide data all looks good.

Screen Shot 2021-08-13 at 3 19 11 PM
wouterdebie commented 3 years ago

Ok, that seems like some regression then. I'm not sure how channels interprets things, but it seems to break with the introduction of tvc-guide-stationid in https://github.com/wouterdebie/locast2tuner/pull/77. What I could do is make it so you can toggle tvc-guide-stationid through configuration.

johnluber commented 3 years ago

Here's 1.48:

tuner.m3u snippet:

EXTM3U

EXTINF:-1 channel-id="1621882471770" tvg-id="channel.1621882471770" tvg-name="PBS (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622015677721_PBS.png" tvg-chno="7004.1" group-title="Raleigh", PBS (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882471770.m3u

EXTINF:-1 channel-id="1621882493172" tvg-id="channel.1621882493172" tvg-name="HD06 (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622016063533_HD06.png" tvg-chno="7004.2" group-title="Raleigh", HD06 (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882493172.m3u

EXTINF:-1 channel-id="1621883442033" tvg-id="channel.1621883442033" tvg-name="PBS (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622016093212_PBS.png" tvg-chno="7004.3" group-title="Raleigh", PBS (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621883442033.m3u

EXTINF:-1 channel-id="1621883433978" tvg-id="channel.1621883433978" tvg-name="PBS (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622016442117_PBS.png" tvg-chno="7004.4" group-title="Raleigh", PBS (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621883433978.m3u

EXTINF:-1 channel-id="1621882619025" tvg-id="channel.1621882619025" tvg-name="NBC (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622016041609_NBC.png" tvg-chno="7005.1" group-title="Raleigh", NBC (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882619025.m3u

EXTINF:-1 channel-id="1621882632632" tvg-id="channel.1621882632632" tvg-name="COZITV (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622015655761_COZITV.png" tvg-chno="7005.2" group-title="Raleigh", COZITV (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882632632.m3u

EXTINF:-1 channel-id="1621882649391" tvg-id="channel.1621882649391" tvg-name="STARTTV (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622016490402_STARTTV.png" tvg-chno="7005.3" group-title="Raleigh", STARTTV (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882649391.m3u

EXTINF:-1 channel-id="1621882668907" tvg-id="channel.1621882668907" tvg-name="ABC (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622015235982_ABC.png" tvg-chno="7011.1" group-title="Raleigh", ABC (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882668907.m3u

EXTINF:-1 channel-id="1621882680908" tvg-id="channel.1621882680908" tvg-name="LCLSESD (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622016892802_LCLSESD.png" tvg-chno="7011.2" group-title="Raleigh", LCLSESD (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882680908.m3u

EXTINF:-1 channel-id="1621882693666" tvg-id="channel.1621882693666" tvg-name="THIS (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622016083503_THIS.png" tvg-chno="7011.3" group-title="Raleigh", THIS (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882693666.m3u

EXTINF:-1 channel-id="1621882718051" tvg-id="channel.1621882718051" tvg-name="CBS (Raleigh)" tvg-logo="https://static.locastnet.org/logo/560/1622015392311_CBS.png" tvg-chno="7017.1" group-title="Raleigh", CBS (Raleigh) (Raleigh)

http://192.168.1.33:6077/watch/1621882718051.m3u

Here's the epg (sorry about formatting)

PBS (Raleigh)7004.1 PBS (Raleigh)WUNCDT7004.11621882471770HD06 (Raleigh)7004.2 HD06 (Raleigh)WUNCDT27004.21621882493172PBS (Raleigh)7004.3 PBS (Raleigh)WUNCDT37004.31621883442033PBS (Raleigh)7004.4 PBS (Raleigh)WUNCDT47004.41621883433978NBC (Raleigh)7005.1 NBC (Raleigh)WRALDT7005.11621882619025COZITV (Raleigh)7005.2 COZITV (Raleigh)WRALDT27005.21621882632632STARTTV (Raleigh)7005.3 STARTTV (Raleigh)WRALDT37005.31621882649391ABC (Raleigh)7011.1 ABC (Raleigh)WTVDDT7011.11621882668907LCLSESD (Raleigh)7011.2 LCLSESD (Raleigh)WTVDDT27011.21621882680908THIS (Raleigh)7011.3 THIS (Raleigh)WTVDDT37011.31621882693666CBS (Raleigh)7017.1 CBS (Raleigh)WNCNDT7017.11621882718051COURT (Raleigh)7017.2 COURT (Raleigh)WNCNDT27017.21621882734038GRIT (Raleigh)7017.3 GRIT (Raleigh)WNCNDT37017.31621882747497MYS (Raleigh)

johnluber commented 3 years ago

Ok, that seems like some regression then. I'm not sure how channels interprets things, but it seems to break with the introduction of tvc-guide-stationid in #77. What I could do is make it so you can toggle tvc-guide-stationid through configuration.

That sounds fine. I love this program is really pretty cool what it does.

wouterdebie commented 3 years ago

I've added a--no_tvc_guide_station option that disables the field in tuner.m3u. 0.1.52 is building now and should fix the issue.

johnluber commented 3 years ago

Nice! Thank you!

On Aug 13, 2021, at 4:09 PM, Wouter de Bie @.***> wrote:

I've added a--no_tvc_guide_station option that disables the field in tuner.m3u. 0.1.52 is building now and should fix the issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wouterdebie/locast2tuner/issues/78#issuecomment-898693164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRUXRZYV4QPZ3N6ANXGPJDT4V3YXANCNFSM5CEDSD6A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

johnluber commented 3 years ago

Installed 1.52 and set the new flag to true and can confirm the issue is resolved.

Thank you so much for being so responsive!

On Aug 13, 2021, at 4:10 PM, John Luber @.***> wrote:

Nice! Thank you!

On Aug 13, 2021, at 4:09 PM, Wouter de Bie @. @.>> wrote:

I've added a--no_tvc_guide_station option that disables the field in tuner.m3u. 0.1.52 is building now and should fix the issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wouterdebie/locast2tuner/issues/78#issuecomment-898693164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRUXRZYV4QPZ3N6ANXGPJDT4V3YXANCNFSM5CEDSD6A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

crackers8199 commented 3 years ago

oof. wish i had seen this earlier. i'm the one that added the gracenote ID.

@johnluber if you're using channels, you don't need any other EPG other than theirs (i.e. you don't need the EPG that locast2tuner provides). as long as that tvc-guide-stationid is present, you can select X-M3U as the guide provider and it'll use all the data channels already has (based on that gracenote station id).

you don't need to use the locast2tuner EPG once that's in place. that was the whole reason i added it to begin with...

wouterdebie commented 3 years ago

It's all good :)

On Wed, Aug 18, 2021, 17:47 Matt Greco @.***> wrote:

oof. wish i had seen this earlier. i'm the one that added the gracenote ID.

@johnluber https://github.com/johnluber if you're using channels, you don't need any other EPG other than theirs (i.e. you don't need the EPG that locast2tuner provides). as long as that tvc-guide-stationid is present, you can select X-M3U as the guide provider and it'll use all the data channels already has (based on that gracenote station id).

you don't need to use the locast2tuner EPG once that's in place. that was the whole reason i added it to begin with...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/wouterdebie/locast2tuner/issues/78#issuecomment-901477861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKABUUW6R6RH66SDEW4R3T5QZ55ANCNFSM5CEDSD6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .